I tried to draw every GitHub red flag I could think of.
Sparky: So, what do you think of my new project? Pretty sweet, huh? |
A github repository: sparkyzhang/awesome_cms. Description: 'finally, a CMS that rocks."
39 commits, 1 branch. Most recent commit: ASDFJKL;A. Folders include 'node_modules', 'file___0_split', '.idea', and 'midi_files'.
Files include 'index.js', 'misc.js', 'stuff.js', 'utils.js', 'things.js', and '.DS_Store'.
There is no readme. |
Cube Drone: Yeah, it's ... great. Good effort.
Developer Pro-Tip: When you read 'utils', mentally substitute it with 'things n' stuff' or 'misc'. Then don't name it any of those things.
Cube Drone: Sparky, explain this code to me. |
Sparky: Okay, this object is the 111th level loader, and this variable is the 11-layer load linker. |
Cube Drone: So you named them 111ll and 11lll?
ll1ll = ll11l.ll(ll111)
Milo: The client wants us to use Hungarian Notation for any new variables we add to their codebase. |
Sparky: Hungarian notation. Gotcha! |
Later, in Code Review: Cube Drone: Sparky, why did you name this variable Szamlalo?
Wait, is this unicode? How did you even get it to compile?
Milo: Look, you can't just check in code like that. You have to go through code review process first. First, you have to run it by lead developer, cardinal (baseball, catholic, or bird), and live unicorn, and get unanimous approval. Then, your code is sent to egyptian underworld. If code is heavier than feather of Ma'at, it is consumed by dread god Ammut for eternity. |
Cube Drone: Come on.
Milo: Okay, but run code by two team members before check-in, okay?
Before it goes into the codebase, it must fight for its life... in the THUNDERDOME.